forked from paradigmxyz/flood
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kch/fix fee history #1
Open
kamilchodola
wants to merge
85
commits into
piwonskp:main
Choose a base branch
from
kamilchodola:kch/fix_fee_History
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results.json was not generated because vegeta was not found. For some reason the error was caught and silenced which made it harder to debug.
1) adding `ipykernel` fixed: ``` jupyter_client.kernelspec.NoSuchKernel: No such kernel named python3 ``` 2) adding `ipython_genutils` fixed: ``` ModuleNotFoundError: No module named 'ipython_genutils' ``` 3) bumping the `nbconvert` version fixed: ``` ImportError: cannot import name 'contextfilter' from 'jinja2' (/home/flood/.local/lib/python3.11/site-packages/jinja2/__init__.py) ``` This was tested within a Docker container, built with: ``` docker build --tag paradigmxyz/flood:latest . ``` Ran with: ``` docker run --rm --volume ${PWD}/output:/output paradigmxyz/flood:latest \ eth_getBlockByNumber NODE:8545 --output /output/ ```
Add existing report example link in report generation section
Fix parquet file download error because of a missing curl binary. This was happening on the `eth_getBalance` test for instance. Note that flood swallowed the exception making the error harder to spot. Update the CI to also test against eth_getBalance which triggers a parquet file download. Also removes the redundant node2, this was a workaround as flood used to crash with only one node. Also unpin the patch version of Python and address a small DRY on the Vegeta version.
…into eth_call_perf
Add possibility to manipulate start/end block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist